This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17971 ) Change subject: PCU: fix f_pcuif_tx_data_cnf(): do not include paging group ...................................................................... PCU: fix f_pcuif_tx_data_cnf(): do not include paging group As it turns out, DATA.cnf shall not contain paging group. Change-Id: I7e0d1bb03fd42fc742f1f3d13a48e9781975dc17 --- M pcu/PCU_Tests_RAW.ttcn 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/17971/1 diff --git a/pcu/PCU_Tests_RAW.ttcn b/pcu/PCU_Tests_RAW.ttcn index 09ff4e3..b79b365 100644 --- a/pcu/PCU_Tests_RAW.ttcn +++ b/pcu/PCU_Tests_RAW.ttcn @@ -249,12 +249,21 @@ * NOTE: it's the responsibility of caller to make sure that pcu_msg contains u.data_req. */ private function f_pcuif_tx_data_cnf(in PCUIF_Message pcu_msg) runs on RAW_PCU_Test_CT { - BTS.send(PCUIF_Message:{ + var PCUIF_Message pcu_msg_cnf := { msg_type := PCU_IF_MSG_DATA_CNF, bts_nr := pcu_msg.bts_nr, spare := pcu_msg.spare, u := { data_cnf := pcu_msg.u.data_req } - }); + }; + + /* PCU wants DATA.cnf containing basically everything that was in DATA.req, + * but PCU_IF_SAPI_PCH is a special case - paging group shall be excluded. */ + if (pcu_msg.u.data_req.sapi == PCU_IF_SAPI_PCH) { + pcu_msg_cnf.u.data_cnf.data := substr(pcu_msg.u.data_req.data, 3, + pcu_msg.u.data_req.len - 3); + } + + BTS.send(pcu_msg_cnf); } private function f_pcuif_rx_imm_ass(out GsmRrMessage rr_imm_ass, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17971 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I7e0d1bb03fd42fc742f1f3d13a48e9781975dc17 Gerrit-Change-Number: 17971 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200429/cee65ed0/attachment.htm>