Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_mt_ping_pong_with_dl_racap_egprs_only

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16687 )

Change subject: pcu: Introduce test TC_mt_ping_pong_with_dl_racap_egprs_only
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16687/6/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16687/6/pcu/PCU_Tests_RAW.ttcn@237 
PS6, Line 237: if (ischosen(dl_block.data)) {
             : 		bsn := dl_block.data.mac_hdr.hdr_ext.bsn;
             : 	} else {
             : 		bsn := dl_block.data_egprs.mac_hdr.bsn1;
             : 	}
not sure if we likely need that more often. If yes, a function might be introduced to hide those details and simply return the bsn for any thpe of dl_block


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16687/6/pcu/PCU_Tests_RAW.ttcn@633 
PS6, Line 633: if (not match(dl_block, dl_template)) {
             : 		dl_template := tr_RLCMAC_DATA_EGPRS;
             : 		dl_template.data_egprs.blocks := ?;
             : 		if (not match(dl_block, dl_template)) {
             : 			setverdict(fail, "Failed to match Packet data: ", dl_block, " vs ", dl_template);
             : 			mtc.stop;
             : 		}
             : 		is_egprs := true;
this also seems like something we may need more often?  In that case, a function "rlcmac_block_is_egprs()" returning bool might be an idea?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16687
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I96e0d28bed749ef657f0b68d0beee3f8471ab3e0
Gerrit-Change-Number: 16687
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Apr 2020 16:51:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200428/efa3edfd/attachment.htm>