This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type ...................................................................... Patch Set 6: Code-Review-1 (3 comments) Marking -1 for explained reasons (+ yourself not really finding a good scenario for it). However, I'd welcome if you could send a patch using osmo_talloc_replace_string() for the existing code. Grep for that function in osmocom code, you'll see lots of examples. https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c File ggsn/ggsn_vty.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c@a286 PS6, Line 286: ggsn->cfg.default_apn = apn; BTW, I am wondering... this looks bad to me. We should be doing osmo_talloc_replace_string() here, so he strdup it. https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c@a295 PS6, Line 295: ggsn->cfg.default_apn = NULL; Same here, osmo_talloc_replace_string. https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c@284 PS6, Line 284: argv[1] = argv[0]; > It took me some time to realize that it's for backwards compatibility with 'default-apn NAME'. […] Agree with fixeria. It's maybe fine doing like keith did but you are probably assuming too much about implementation there, and may become problematic if implementation changes at a later pointer. Doing like fixeria says avoids this kind of issue. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 6 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Mon, 27 Apr 2020 10:11:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <axilirator at gmail.com> Comment-In-Reply-To: keith <keith at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200427/b9a40597/attachment.htm>