Change in osmo-ggsn[master]: Add default APN for each EUA Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Mon Apr 27 04:50:58 UTC 2020


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 )

Change subject: Add default APN for each EUA Type
......................................................................


Patch Set 6:

(1 comment)

> I agree with you the only real use for the feature you are adding
 > is in the event you really want to have default working
 > configurations for PDP contexts requesting v4, v6 or v4v6. If you
 > think that's useful we can merge it, otherwise I see no point.

Sorry to consume your time with somewhat pointless CR, although it's all good learning for me! Thanks for that. I think I don't want to merge this, but would appreciate if you would answer the question about assigning to argv elements. Looks possibly dangerous to me. but I guess it might be ok depending what goes on with argc/v?

I think then I would just publish this to a personal branch in case it ever comes up again. 

I was thinking about it - it was the default example config that confused me;

Is that a usual config? Why would you configure separate APNs with their associated tun interfaces in a real network for v4 and v4v6? What I see is a mix of v4 and v4v6 PDP context activations. I suppose the operator config varies depending on periods of sale of SIMs or on device or something.

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn/ggsn_vty.c@284 
PS6, Line 284: 		argv[1] = argv[0];
Is this legal?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6
Gerrit-Change-Number: 17941
Gerrit-PatchSet: 6
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 27 Apr 2020 04:50:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200427/6e03b8ee/attachment.htm>


More information about the gerrit-log mailing list