This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17870 ) Change subject: SMS-over-GSUP: clarify error message about unexpected MO/MT SMS ...................................................................... SMS-over-GSUP: clarify error message about unexpected MO/MT SMS Change-Id: I34b25764f9ce9b09ccd28cf23fea01028d0828e0 --- M src/libmsc/gsm_04_11_gsup.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/libmsc/gsm_04_11_gsup.c b/src/libmsc/gsm_04_11_gsup.c index b6b798f..dfc90cc 100644 --- a/src/libmsc/gsm_04_11_gsup.c +++ b/src/libmsc/gsm_04_11_gsup.c @@ -152,8 +152,8 @@ /* Make sure that 'SMS over GSUP' is expected */ if (!net->sms_over_gsup) { /* TODO: notify sender about that? */ - LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO SMS over GSUP, " - "ignoring message...\n"); + LOGP(DLSMS, LOGL_NOTICE, "Unexpected MO SMS over GSUP " + "(sms-over-gsup is not enabled), ignoring message...\n"); return -EIO; } @@ -243,8 +243,8 @@ /* Make sure that 'SMS over GSUP' is expected */ if (!net->sms_over_gsup) { - LOGP(DLSMS, LOGL_NOTICE, "Unexpected MT SMS over GSUP, " - "ignoring message...\n"); + LOGP(DLSMS, LOGL_NOTICE, "Unexpected MT SMS over GSUP " + "(sms-over-gsup is not enabled), ignoring message...\n"); /* TODO: notify sender about that? */ return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17870 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I34b25764f9ce9b09ccd28cf23fea01028d0828e0 Gerrit-Change-Number: 17870 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200426/e7e09fe1/attachment.htm>