Change in osmo-ggsn[master]: Add default APN for each EUA Type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Sat Apr 25 04:11:21 UTC 2020


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 )

Change subject: Add default APN for each EUA Type
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn.c 
File ggsn/ggsn.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn.c@458 
PS4, Line 458: 		if (pdp->eua.l < 2 || pdp->eua.v[0] != 0xf1)
taken from lib/in46_addr.c Lines 322-326


https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn.c@473 
PS4, Line 473: default_apn_done:
as you can see I tried a few options here. 

If you don't like the goto, dear code reviewer, please point to the right way. :)


https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn_vty.c 
File ggsn/ggsn_vty.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4/ggsn/ggsn_vty.c@300 
PS4, Line 300: 	"default-apnv6 NAME",
come to think of it now, 
one might prefer here  default-apn-v6

Let's see if the concept is accepted first.. Then I can change that.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17941
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6
Gerrit-Change-Number: 17941
Gerrit-PatchSet: 4
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Sat, 25 Apr 2020 04:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200425/5aec65b1/attachment.htm>


More information about the gerrit-log mailing list