Change in osmo-bts[master]: lc15: Fix mismathing signature in callback provided

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Apr 24 20:59:47 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/17937 )


Change subject: lc15: Fix mismathing signature in callback provided
......................................................................

lc15: Fix mismathing signature in callback provided

Fixes following compilation warning:

/osmo-bts/src/osmo-bts-litecell15/l1_if.c: In function ‘dsp_alive_timer_cb’:
/osmo-bts/src/osmo-bts-litecell15/l1_if.c:1643:33: warning: passing argument 3 of ‘l1if_req_compl’ from incompatible pointer type [-Wincompatible-pointer-types]
 1643 |  rc = l1if_req_compl(fl1h, msg, dsp_alive_compl_cb, NULL);
      |                                 ^~~~~~~~~~~~~~~~~~
      |                                 |
      |                                 void (*)(struct gsm_bts_trx *, struct msgb *, void *)
/osmo-bts/src/osmo-bts-litecell15/l1_if.c:220:21: note: expected ‘int (*)(struct gsm_bts_trx *, struct msgb *, void *)’ but argument is of type ‘void (*)(struct gsm_bts_trx *, struct msgb *, void *)’
  220 |      l1if_compl_cb *cb, void *data)
      |      ~~~~~~~~~~~~~~~^~

Change-Id: Id80d5a52cbccce54456205dec230a0b546b8b310
---
M src/osmo-bts-litecell15/l1_if.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/37/17937/1

diff --git a/src/osmo-bts-litecell15/l1_if.c b/src/osmo-bts-litecell15/l1_if.c
index 0e334d2..23f7c3d 100644
--- a/src/osmo-bts-litecell15/l1_if.c
+++ b/src/osmo-bts-litecell15/l1_if.c
@@ -1605,7 +1605,7 @@
 }
 
 #if LITECELL15_API_VERSION >= LITECELL15_API(2,1,7)
-static void dsp_alive_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp, void *data)
+static int dsp_alive_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp, void *data)
 {
 	Litecell15_Prim_t *sysp = msgb_sysprim(resp);
 	Litecell15_IsAliveCnf_t *sac = &sysp->u.isAliveCnf;
@@ -1616,6 +1616,7 @@
 			get_value_string(lc15bts_sysprim_names, sysp->id), sac->status, trx->nr);
 
 	msgb_free(resp);
+	return 0;
 }
 
 static void dsp_alive_timer_cb(void *data)

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17937
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id80d5a52cbccce54456205dec230a0b546b8b310
Gerrit-Change-Number: 17937
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200424/fe93f0a5/attachment.htm>


More information about the gerrit-log mailing list