Change in osmo-bts[master]: measurement: expect at least 1 SUB frame for AMR

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17929 )

Change subject: measurement: expect at least 1 SUB frame for AMR
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c 
File src/common/measurement.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@623 
PS1, Line 623: 			 * negotiated in AMD, so we can not know if and how many
AMD? you mean AMR


https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@627 
PS1, Line 627: 				    num_meas_sub_expect - num_meas_sub) {
better keep this in one line, it's more readable.


https://gerrit.osmocom.org/c/osmo-bts/+/17929/1/src/common/measurement.c@665 
PS1, Line 665: 	if (lchan->tch_mode != GSM48_CMODE_SPEECH_AMR) {
Can we move all these checks together with the ones above in line 643 please?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17929
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1fd91b576ff7274caa6d4356bcd7a4fa4311219d
Gerrit-Change-Number: 17929
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Apr 2020 15:17:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200422/a6e185b0/attachment.htm>