Change in osmo-bts[master]: dtx: add detection of AMR DTX frames for osmo-bts-trx

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17221 )

Change subject: dtx: add detection of AMR DTX frames for osmo-bts-trx
......................................................................


Patch Set 4: Code-Review-1

(10 comments)

https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/include/osmo-bts/scheduler_backend.h 
File include/osmo-bts/scheduler_backend.h:

https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/include/osmo-bts/scheduler_backend.h@57 
PS4, Line 57: 			   uint8_t is_sub);
bool


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/common/scheduler.c 
File src/common/scheduler.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/common/scheduler.c@743 
PS4, Line 743: 			   uint8_t is_sub)
bool is_sub


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/common/scheduler.c@762 
PS4, Line 762: 	l1sap->u.tch.is_sub = is_sub & 1;
since it's a bool ,simply assign.


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c 
File src/osmo-bts-trx/scheduler_trx.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1143 
PS4, Line 1143: 	uint8_t is_sub = 0;
bool is_sub = false;


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1210 
PS4, Line 1210: 		 * voce frame after the AFS_ONSET frame actually is the first
typo: voce -> voice


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1211 
PS4, Line 1211: 		 * real voice frame that is will also result into an RTP frame. */
"that is will also" I don't understand this, please fix.


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1228 
PS4, Line 1228: 			is_sub = 1;
is_sub = true


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1250 
PS4, Line 1250: 			if (chan_state->amr_last_dtx == AMR_OTHER)
either 
"if {} else {}"
or
" if else "


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1382 
PS4, Line 1382: 	uint8_t is_sub = 0;
bool


https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1497 
PS4, Line 1497: 			if (chan_state->amr_last_dtx == AMR_OTHER)
either 
"if {} else {}"
or
" if else "



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17221
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5afe730fff2fa3199a5913b0de4f5c7b23a39f31
Gerrit-Change-Number: 17221
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Apr 2020 12:07:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200422/039e80df/attachment.htm>