This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
keith gerrit-no-reply at lists.osmocom.orgkeith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c File src/osmo-bts-litecell15/l1_if.c: https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1608 PS4, Line 1608: static void dsp_alive_compl_cb(struct gsm_bts_trx *trx, struct msgb *resp, void *data) > Could you be explicit on which change do you want to be made? The one that doesn't introduce a compiler warning. At this point, I'd rather defer to somebody else, as I don't know enough about coding standards and style to say if the correct thing here is void because nothing to return and so what if everything else says it should be int. In terms of following the oc2g code, i would just point out that was 99% bulk merged in https://gerrit.osmocom.org/#/c/osmo-bts/+/11447/ and possibly (probably) contains the same non compliance with osmo standards? https://gerrit.osmocom.org/c/osmo-bts/+/17855/4/src/osmo-bts-litecell15/l1_if.c@1722 PS4, Line 1722: fl1h->hw_alive.dsp_alive_timer.cb = dsp_alive_timer_cb; > Which logic error you see? I read it wrong; that -EIO won't happen due to the L1 not responding. I still feel however that we're introducing bad code here. Maybe that's fine if it'll all get cleaned up in subsequent unification of oc2g/lc15 I'll just defer.. see if somebody else gives +1 That's all from me. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17855 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ib16e7d423fc7030573acd86fbd356ae96697ed5d Gerrit-Change-Number: 17855 Gerrit-PatchSet: 4 Gerrit-Owner: rafael2k <rafael at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: rafael2k <rafael at rhizomatica.org> Gerrit-CC: keith <keith at rhizomatica.org> Gerrit-Comment-Date: Mon, 20 Apr 2020 19:29:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <keith at rhizomatica.org> Comment-In-Reply-To: rafael2k <rafael at rhizomatica.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/78430eaf/attachment.htm>