Change in osmo-uecups[master]: work around bogus compiler warnings

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Apr 20 10:55:27 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-uecups/+/17885 )

Change subject: work around bogus compiler warnings
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-uecups/+/17885/1/daemon/tun_device.c 
File daemon/tun_device.c:

https://gerrit.osmocom.org/c/osmo-uecups/+/17885/1/daemon/tun_device.c@207 
PS1, Line 207: 		osmo_strlcpy(ifr.ifr_name, name, IFNAMSIZ);
osmo_strlcpy adds a null character at the end, and if I recall correctly buffers of IFNAMSIZ can be non-null terminated (or had some kind of particularity I don't fully remember now), so it's possible that use of strncpy here is fine. One would need to verify that just in case.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/17885
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-uecups
Gerrit-Branch: master
Gerrit-Change-Id: I9170e4de857c1f3e003a480b12dd16fe796ec763
Gerrit-Change-Number: 17885
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Apr 2020 10:55:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200420/ea4efbe0/attachment.htm>


More information about the gerrit-log mailing list