Change in pysim[master]: Populate AIDs present on the UICC

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Apr 19 08:25:35 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17833 )

Change subject: Populate AIDs present on the UICC
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

https://gerrit.osmocom.org/c/pysim/+/17833/3/pysim-testdata/fakemagicsim.ok 
File pysim-testdata/fakemagicsim.ok:

https://gerrit.osmocom.org/c/pysim/+/17833/3/pysim-testdata/fakemagicsim.ok@1 
PS3, Line 1: (dev=5) inter
> I'm not quite sure about this change. […]
I think we need to address this separately.  The message should not be printed at all during the tests. The PC/SC device numbers are not stable over time (think of USB enumeration order, hotplug order, ...) so they are not reproducible and shouldn't be printed.

I created https://osmocom.org/issues/4503 to track this.


https://gerrit.osmocom.org/c/pysim/+/17833/3/pysim-testdata/fakemagicsim.ok@4 
PS3, Line 4: C
I think the error message should be more oriented towards the user.  What we want to say here in a user-friendly way is: "Can't read AIDs from SIM; probably a classic SIM card without UICC/USIM functionailty"? This sounds more like anormal message, rather than an error.

This can be adressed in a later patch.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4d0d8f5f1e8cb252be55a2995b730927cfa7004d
Gerrit-Change-Number: 17833
Gerrit-PatchSet: 3
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Sun, 19 Apr 2020 08:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200419/26149f35/attachment.htm>


More information about the gerrit-log mailing list