This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17853 ) Change subject: select.c: Introduce support for signalfd ...................................................................... Patch Set 2: (1 comment) > Patch Set 2: > > (1 comment) > > I'm not sure whether these APIs are really needed/helpful, specially having the wrapper struct, but fine. well, it is about convenience. I assume most of our programs will use this, so I think we should make it easy to use. As the number of signalfd's is likely always very small (there are only few singals to begin with), having a few dynamica allocations at the start of the program shouldn't be controversial. The wrapper avoids every program having to implement their own read (and getting that error handling right). https://gerrit.osmocom.org/c/libosmocore/+/17853/2/src/select.c File src/select.c: https://gerrit.osmocom.org/c/libosmocore/+/17853/2/src/select.c@405 PS2, Line 405: if (rc < 0) { > wondering how could this happen. […] thanks, nice catch. I chopied it from the timerfd code above, which has the same issue :/ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17853 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If8d89dd1f6989e1cd9b9367fad954d65f91ada30 Gerrit-Change-Number: 17853 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Sat, 18 Apr 2020 19:14:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200418/7a0fc65a/attachment.htm>