Change in libosmocore[master]: exec: Introduce osmo_system_nowait2() to allow specify a user

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Apr 18 13:00:35 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17852 )

Change subject: exec: Introduce osmo_system_nowait2() to allow specify a user
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/17852/1/src/exec.c 
File src/exec.c:

https://gerrit.osmocom.org/c/libosmocore/+/17852/1/src/exec.c@217 
PS1, Line 217: 		pw = getpwnam(user);
> Use getpwnam_r() instead, so this API can be used in multithread apps (though indeed it's probably n […]
I wanted to detect situations where the username is invalid/unknown in the parent so it can be reported before even forking.  Will change to getpwnam_r()


https://gerrit.osmocom.org/c/libosmocore/+/17852/1/src/exec.c@248 
PS1, Line 248: exit
> It probably makes sense to fprintf(stderr) something here, to get some kind of feedback if something […]
@fixeria: it's not the parent process but only the child that terminates [before it ever execs the requested program].  You cannot return anything to the parent at this point anymore.

@pespin: ACK



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17852
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If1431f930f72a8d6c1d102426874a11b7a2debd9
Gerrit-Change-Number: 17852
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sat, 18 Apr 2020 13:00:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200418/56a74b28/attachment.htm>


More information about the gerrit-log mailing list