Change in libosmocore[master]: select.c: Introduce support for signalfd

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Apr 17 22:25:08 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17853 )

Change subject: select.c: Introduce support for signalfd
......................................................................


Patch Set 1:

(3 comments)

I wonder where why is this extra structure needed at all. sigset is only used during setup, and even that can be easily done manually with the generic ofd...

https://gerrit.osmocom.org/c/libosmocore/+/17853/1/include/osmocom/core/select.h 
File include/osmocom/core/select.h:

https://gerrit.osmocom.org/c/libosmocore/+/17853/1/include/osmocom/core/select.h@74 
PS1, Line 74: struct signalfd_siginfo;
osmo_signalfd_siginfo?


https://gerrit.osmocom.org/c/libosmocore/+/17853/1/src/select.c 
File src/select.c:

https://gerrit.osmocom.org/c/libosmocore/+/17853/1/src/select.c@435 
PS1, Line 435: 	fd = signalfd(-1, &osfd->sigset, O_NONBLOCK);
are you sure O_NONBLOCK is correct here? I don't find it in "man signalfd", but there's SFD_NONBLOCK


https://gerrit.osmocom.org/c/libosmocore/+/17853/1/src/select.c@445 
PS1, Line 445: return NULL;
> Shouldn't we free() osfd here?
agree with fixeria



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17853
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If8d89dd1f6989e1cd9b9367fad954d65f91ada30
Gerrit-Change-Number: 17853
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 17 Apr 2020 22:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200417/4289f1b6/attachment.htm>


More information about the gerrit-log mailing list