Change in osmo-pcu[master]: HACK: always assign TAI=0 on PTCCH/U, check SAPI of PH-RA.ind

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Apr 15 20:36:13 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17830 )


Change subject: HACK: always assign TAI=0 on PTCCH/U, check SAPI of PH-RA.ind
......................................................................

HACK: always assign TAI=0 on PTCCH/U, check SAPI of PH-RA.ind

Change-Id: I5aadff0d019c7e1cb78ce0327c11f83773fcc7f5
---
M src/encoding.cpp
M src/osmo-bts-sysmo/sysmo_l1_if.c
2 files changed, 11 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/30/17830/1

diff --git a/src/encoding.cpp b/src/encoding.cpp
index a4a14dd..34d6279 100644
--- a/src/encoding.cpp
+++ b/src/encoding.cpp
@@ -118,6 +118,9 @@
 {
 	int rc;
 
+	/* HACK: always assign TAI=0 (for testing purposes) */
+	tai = 0x00;
+
 	if (tai < 0) { /* No TIMING_ADVANCE_INDEX: */
 		SET_0(dest);
 	} else { /* TIMING_ADVANCE_INDEX: */
@@ -131,6 +134,8 @@
 
 static inline bool write_tai(bitvec *dest, unsigned& wp, int8_t tai)
 {
+	/* HACK: always assign TAI=0 (for testing purposes) */
+	tai = 0x00;
 	if (tai < 0) { /* No TIMING_ADVANCE_INDEX: */
 		bitvec_write_field(dest, &wp, 0, 1);
 		return false;
diff --git a/src/osmo-bts-sysmo/sysmo_l1_if.c b/src/osmo-bts-sysmo/sysmo_l1_if.c
index 0ab0808..f335218 100644
--- a/src/osmo-bts-sysmo/sysmo_l1_if.c
+++ b/src/osmo-bts-sysmo/sysmo_l1_if.c
@@ -237,6 +237,12 @@
 
 	DEBUGP(DL1IF, "Rx PH-RA.ind");
 
+	/* Check SAPI of PTCCH/U (TAI=0) */
+	if (ra_ind->u32Fn % 416 == 12) {
+		LOGP(DL1IF, LOGL_FATAL, "========= Rx PTCCH/U (TAI=0) on fn=%u sapi=%s\n",
+		     ra_ind->u32Fn, get_value_string(femtobts_l1sapi_names, ra_ind->sapi));
+	}
+
 	switch (ra_ind->sapi) {
 	case GsmL1_Sapi_Pdtch:
 	case GsmL1_Sapi_Prach:

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17830
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5aadff0d019c7e1cb78ce0327c11f83773fcc7f5
Gerrit-Change-Number: 17830
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200415/c866fe43/attachment.htm>


More information about the gerrit-log mailing list