Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Tue Apr 14 15:01:42 UTC 2020


keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17808 )

Change subject: osmo-bts-litecell15: Implement missing features.
......................................................................


Patch Set 2:

(1 comment)

> > Description set to "I'm not sure why there is a case with failing
 > > build, as the software build and runs fine in the LC 1.5."
 > 


l1_if.c:1714:36: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types]
  fl1h->hw_alive.dsp_alive_timer.cb = dsp_alive_timer_cb;

https://gerrit.osmocom.org/c/osmo-bts/+/17808/2/src/osmo-bts-litecell15/oml.c 
File src/osmo-bts-litecell15/oml.c:

https://gerrit.osmocom.org/c/osmo-bts/+/17808/2/src/osmo-bts-litecell15/oml.c@1805 
PS2, Line 1805: 		    TLVP_LEN(new_attr, NM_ATT_TSC) >= 1 &&
why? please see 
https://git.osmocom.org/libosmocore/tree/include/osmocom/gsm/tlv.h#n470



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17808
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id41bba798440b00a3b11441b64b2e8094a946bf2
Gerrit-Change-Number: 17808
Gerrit-PatchSet: 2
Gerrit-Owner: rafael2k <rafael at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: keith <keith at rhizomatica.org>
Gerrit-Comment-Date: Tue, 14 Apr 2020 15:01:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200414/54b5bca1/attachment.htm>


More information about the gerrit-log mailing list