This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17805 ) Change subject: transceiver: get rid of the ctrl threads ...................................................................... Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/osmo-trx/+/17805/4/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/17805/4/Transceiver52M/Transceiver.cpp@759 PS4, Line 759: Just noticed: other functions use 2 spaces as tab, while the new code uses 4. I know this is rather cosmetic and is not critical at all, but still would be good to keep the coding style consistent. https://gerrit.osmocom.org/c/osmo-trx/+/17805/4/Transceiver52M/Transceiver.cpp@762 PS4, Line 762: s.txmsgqueue.push_back(m); > is m copied/cloned where? otherwise it will be destroyed when function ctrl_sock_handle_rx() exits ( […] Good question. We may need std::move() here. https://gerrit.osmocom.org/c/osmo-trx/+/17805/4/Transceiver52M/Transceiver.cpp@765 PS4, Line 765: return I would remove this meaningless 'return'. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642a34451e1825eafecf71a902df916ccee7944c Gerrit-Change-Number: 17805 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 13 Apr 2020 16:59:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200413/2eff5a4d/attachment.htm>