This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17805 ) Change subject: transceiver: get rid of the ctrl thread ...................................................................... Patch Set 3: (5 comments) https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/Transceiver.h File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/Transceiver.h@153 PS3, Line 153: strncpy(data,src,99); Simply use OSMO_STRLCPY_ARRAY() https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/Transceiver.h@275 PS3, Line 275: This new empty line can be dropped. https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/Transceiver.cpp@239 PS3, Line 239: OSMO_SOCK_F_BIND | OSMO_SOCK_F_CONNECT); wrong indentation https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/Transceiver.cpp@783 PS3, Line 783: rc = write(s.conn_bfd.fd, m.data, strlen(m.data) + 1); not urgent, but looks like we can cache strlen(m.data) in m during m constructor (return of OSMO_STRLCPY_ARRAY) https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/osmo-trx.cpp File Transceiver52M/osmo-trx.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/17805/3/Transceiver52M/osmo-trx.cpp@82 PS3, Line 82: This new empty line can be dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642a34451e1825eafecf71a902df916ccee7944c Gerrit-Change-Number: 17805 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Mon, 13 Apr 2020 14:20:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200413/6a12cfc6/attachment.htm>