This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/17805 ) Change subject: transceiver: get rid of the ctrl thread ...................................................................... Patch Set 2: (5 comments) https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.h File Transceiver52M/Transceiver.h: https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.h@160 PS2, Line 160: std::deque<ctrl_msg> txmsgqueue; > can't we just use convenient stl containers instead of arcane stuff if we do c++? osmo_wqueue is also convenient and matches more what we do in most CNI code where C is used. Not a hard blocker though. https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.cpp File Transceiver52M/Transceiver.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.cpp@a161 PS2, Line 161: if (mCtrlSockets[i] >= 0) > no, because this is c++, and resources can clean up themselves upon destruction.. Ah I see now it's done in struct ctrl_sock_state destructor, ack. https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.cpp@817 PS2, Line 817: msgLen = read(bfd->fd, buffer, sizeof(cmd_received.data)); > see header for reason, a simple struct wrap of a char array is still far less complicated than the w […] Ack https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.cpp@820 PS2, Line 820: osmo_signal_dispatch(SS_MAIN, S_MAIN_STOP_REQUIRED, NULL); This should probably go into Transceiver::ctrl_sock_cb() https://gerrit.osmocom.org/c/osmo-trx/+/17805/2/Transceiver52M/Transceiver.cpp@840 PS2, Line 840: transceiver->stop(); > this is c++ and we can't have callbacks from somewhere for member functions, where would they get th […] Transceiver::driveControl() is not a callback function, in line 168 do transceiver->driveControl() and you avoid changing like 50 lines in this function. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/17805 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I642a34451e1825eafecf71a902df916ccee7944c Gerrit-Change-Number: 17805 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Sun, 12 Apr 2020 14:59:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: Hoernchen <ewild at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200412/989a1699/attachment.htm>