This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17759 )
Change subject: trx_toolkit/app_common: introduce auxiliary add_log_handler()
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/c/osmocom-bb/+/17759/2/src/target/trx_toolkit/app_common.py
File src/target/trx_toolkit/app_common.py:
https://gerrit.osmocom.org/c/osmocom-bb/+/17759/2/src/target/trx_toolkit/app_common.py@53
PS2, Line 53: lo = (argv.log_level, argv.log_fmt)
> I'm not following you. why not simply calling: […]
I mean in the next change we add more options, then some day we may want more... So I personally consider this:
lh = (aaaaaaaaa, bbbbbbbbbbb, cccccccccccccc, ddddddd,
eeeeeeeeeeee, fffffffffffff, gg, hhhhhhhhhh)
----->
less ugly than this:
self.add_log_handler(lh, aaaaaaaaa, bbbbbbbbbbb, cccccccccccccc,
ddddddd, eeeeeeeeeeee, fffffffffffff,
gg, hhhhhhhhhh)
------------------------>
This is just a (groundless) style preference...
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17759
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ied32764cf1c34dc7e0f746f4f085ea20168775cb
Gerrit-Change-Number: 17759
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Apr 2020 22:26:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200408/ba271bd8/attachment.htm>