This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17746 )
Change subject: tests/test-helpers: fix endianness: do not print uint32_t as raw bytes
......................................................................
tests/test-helpers: fix endianness: do not print uint32_t as raw bytes
This unit test would not pass on big-endian machines.
Change-Id: I60dbcaa89b031c9a81c35e1dd0d9c963d486014c
---
M src/tests/test-helpers.c
M src/tests/test-helpers.ok
2 files changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/46/17746/1
diff --git a/src/tests/test-helpers.c b/src/tests/test-helpers.c
index d7ad758..08236fa 100644
--- a/src/tests/test-helpers.c
+++ b/src/tests/test-helpers.c
@@ -98,8 +98,7 @@
printf("Decoding back to uint32_t: 0x%x\n", res);
ASSERT(res == val1);
- printf("Encoding %s to 24-bit asn.1 bitstring\n",
- osmo_hexdump_nospc((unsigned char*)&val1, 3));
+ printf("Encoding 0x%x to 24-bit asn.1 bitstring\n", val1);
asn1_u24_to_bitstring(&enc, &tmpval, val1);
ASSERT(enc.size == 24/8);
diff --git a/src/tests/test-helpers.ok b/src/tests/test-helpers.ok
index ddfea78..f2e466f 100644
--- a/src/tests/test-helpers.ok
+++ b/src/tests/test-helpers.ok
@@ -6,7 +6,7 @@
Encoding 0xdeadbeef to asn.1 bitstring
Encoded: 20deadbeef
Decoding back to uint32_t: 0xdeadbeef
-Encoding efbead to 24-bit asn.1 bitstring
+Encoding 0xdeadbeef to 24-bit asn.1 bitstring
Encoded: 18adbeef
Decoding string from asn.1: 0123456789012345
Decoding large string from asn1: 0123456789012345678901234567890
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/17746
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I60dbcaa89b031c9a81c35e1dd0d9c963d486014c
Gerrit-Change-Number: 17746
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200407/c9e5aaa7/attachment.htm>