Change in libosmocore[master]: dtx: add decoding for AMR-DTX frames

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Apr 6 13:55:11 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17095 )

Change subject: dtx: add decoding for AMR-DTX frames
......................................................................


Patch Set 12:

(2 comments)

This should now work as it should

https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_amr_dtx.c 
File src/coding/gsm0503_amr_dtx.c:

https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_amr_dtx.c@228 
PS10, Line 228: static inline bool detect_afs_sid_first(int *n_errors, int *n_bits_total, const ubit_t *ubits)
> I would argue you can remove all that explicit 'inline'. […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_coding.c 
File src/coding/gsm0503_coding.c:

https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_coding.c@2203 
PS10, Line 2203: if (*dtx == AFS_SID_UPDATE) 
> style-wise, I would have used a switch (*dtx) here, but please don't change it now, just mentioning  […]
I was thinking about it, but with ahs the logic requires an if statement and I wanted to give both implementation a similar look.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17095
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2bbdb39ea20461ca08b2e6f1a33532cb55cd5195
Gerrit-Change-Number: 17095
Gerrit-PatchSet: 12
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 06 Apr 2020 13:55:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200406/c9db84f1/attachment.htm>


More information about the gerrit-log mailing list