This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17730 ) Change subject: vty: clarify EGPRS Packet Channel Request message support ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h File include/osmocom/bsc/rest_octets.h: https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/include/osmocom/bsc/rest_octets.h@85 PS1, Line 85: bool ctrl_ack_type_use_block; /* use PACKET CONTROL ACKNOWLEDGMENT */ > This one seems duplicated too? No. Why do you think so? https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/17730/1/src/osmo-bsc/bsc_vty.c@3184 PS1, Line 3184: if (bts->gprs.mode != BTS_GPRS_EGPRS) { > Does this really make sense here? You are deactivating it. Not sure. Probably I should remove this check... -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/17730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ied5bd10a806aeeac65ef32339d4ab0e3700e5da9 Gerrit-Change-Number: 17730 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 06 Apr 2020 12:29:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200406/7ebb0623/attachment.htm>