This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17708 ) Change subject: l1if: fix pcu_rx_rach_ind(): also send PTCCH/U to GSMTAP ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/17708/1/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/17708/1/src/pcu_l1_if.cpp@438 PS1, Line 438: static int pcu_rx_rach_ind(struct gsm_pcu_if_rach_ind *rach_ind) is this also called for instance during osmo-pcu-sysmo direct phy case? otherwise you'd be dropping the gsmtap_send in that case? https://gerrit.osmocom.org/c/osmo-pcu/+/17708/1/src/pcu_l1_if.cpp@448 PS1, Line 448: #define send_gsmtap_ra(category, chan) do { \ You don't really need this, you are calling it twice. and it's one function call... -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5cc4c3d2522215a31924121f83fcc2ac9ac6fe9c Gerrit-Change-Number: 17708 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 02 Apr 2020 13:39:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200402/bd84212c/attachment.htm>