This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
srs_andre gerrit-no-reply at lists.osmocom.orgsrs_andre has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 ) Change subject: iperf3: add config to adjust the duration of the iperf run ...................................................................... Patch Set 9: (4 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/src/osmo_gsm_tester/iperf3.py File src/osmo_gsm_tester/iperf3.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/src/osmo_gsm_tester/iperf3.py@159 PS8, Line 159: values = dict(iperf3cli=config.get_defaults('iperf3cli')) > You acked my commit but didn't apply the change :) sorry, forgot to comment. I've changed it but it wasn't picking up the passed argument, so I needed to revert it again, this way it is working as expected. sorry https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/src/osmo_gsm_tester/iperf3.py@171 PS8, Line 171: time_sec_final = int(time_sec) > If coming from argument, then it should be an integer, so having time_sec_final = time_sec should be […] Ack https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_dl.py File suites/4g/iperf3_dl.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_dl.py@35 PS8, Line 35: proc = iperf3cli.prepare_test_proc(True, ue.netns(), time_sec=None) > simply remove the time_sec=None from here, default will apply. Ack https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_ul.py File suites/4g/iperf3_ul.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651/8/suites/4g/iperf3_ul.py@35 PS8, Line 35: proc = iperf3cli.prepare_test_proc(False, ue.netns(), time_sec=None) > simply remove the time_sec=None from here, default will apply. Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/17651 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: Iff28816f83670751e9e91de31ec59b1b0ad8fc0d Gerrit-Change-Number: 17651 Gerrit-PatchSet: 9 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-Comment-Date: Wed, 01 Apr 2020 12:38:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200401/c0f56d48/attachment.htm>