Change in osmo-ttcn3-hacks[master]: BTS: fix as_l1_count_paging(): do not count PCH filling messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 1 10:06:32 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683 )

Change subject: BTS: fix as_l1_count_paging(): do not count PCH filling messages
......................................................................

BTS: fix as_l1_count_paging(): do not count PCH filling messages

Since build #842, both TC_paging_{i|t}msi_80percent started to fail:

  "BTS_Tests.ttcn:3051 : Expected 271 pagings but have 284"
      BTS_Tests.ttcn:6414 BTS_Tests control part
      BTS_Tests.ttcn:3051 TC_paging_imsi_80percent testcase

  "BTS_Tests.ttcn:3075 : Expected 543 pagings but have 553"
      BTS_Tests.ttcn:6415 BTS_Tests control part
      BTS_Tests.ttcn:3075 TC_paging_tmsi_80percent testcase

As it turns out, since If5339c7a91b4e0188194f1cd935798f153974e01
TITAN can decode PCH filling messages with no Mobile Identity.
We should not count them in as_l1_count_paging(), as they're
sent by osmo-bts itself.

Change-Id: I420f36ed000b1c2488fbe500c33a8161e27d20e3
Fixes: OS#4475
---
M bts/BTS_Tests.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index a2b4af7..794d604 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -2866,7 +2866,10 @@
 
 		check_pch_fn(dl.dl_info.frame_nr, cfg.bs_ag_blks_res);
 
-		if (match(rr, tr_PAGING_REQ1)) {
+		if (match(rr, tr_PAGING_REQ1(tr_MI_LV(t_MI_NoIdentity(?))))) {
+			/* Ignore empty RR Paging Request (PCH filling) messages.
+			 * TODO: does it make sense to count them? */
+		} else if (match(rr, tr_PAGING_REQ1)) {
 			num_paging_rcv_msgs := num_paging_rcv_msgs + 1;
 			num_paging_rcv_ids := num_paging_rcv_ids + 1;
 			if (ispresent(rr.msgs.rrm.pagingReq_Type1.mobileIdentity2)) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/17683
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I420f36ed000b1c2488fbe500c33a8161e27d20e3
Gerrit-Change-Number: 17683
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200401/ecd2838f/attachment.htm>


More information about the gerrit-log mailing list