Change in openbsc[master]: debug: use only LOGL_NOTICE as default loglevel

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/17605 )

Change subject: debug: use only LOGL_NOTICE as default loglevel
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/openbsc/+/17605/1/openbsc/src/libcommon/debug.c 
File openbsc/src/libcommon/debug.c:

https://gerrit.osmocom.org/c/openbsc/+/17605/1/openbsc/src/libcommon/debug.c@123 
PS1, Line 123: [DGPRS] = {
             : 		.name = "DGPRS",
             : 		.description = "GPRS Packet Service",
             : 		.enabled = 1, .loglevel = LOGL_NOTICE,
             : 	},
             : 	[DNS] = {
             : 		.name = "DNS",
             : 		.description = "GPRS Network Service (NS)",
             : 		.enabled = 1, .loglevel = LOGL_NOTICE,
             : 	},
             : 	[DBSSGP] = {
             : 		.name = "DBSSGP",
             : 		.description = "GPRS BSS Gateway Protocol (BSSGP)",
             : 		.enabled = 1, .loglevel = LOGL_NOTICE,
             : 	},
             : 	[DLLC] = {
             : 		.name = "DLLC",
             : 		.description = "GPRS Logical Link Control Protocol (LLC)",
             : 		.enabled = 1, .loglevel = LOGL_NOTICE,
             : 	},
             : 	[DSNDCP] = {
             : 		.name = "DSNDCP",
             : 		.description = "GPRS Sub-Network Dependent Control Protocol (SNDCP)",
             : 		.enabled = 1, .loglevel = LOGL_NOTICE,
             : 	},
those subsystems don't exist in the BSC, and hence they should be removed completely.  This dates back to a time where the SGSN + gbproxy were part of the same git repo as openbsc, and they shared this debug.c file.


https://gerrit.osmocom.org/c/openbsc/+/17605/1/openbsc/src/libcommon/debug.c@158 
PS1, Line 158: [DSMPP] = {
             : 		.name = "DSMPP",
             : 		.description = "SMPP interface for external SMS apps",
             : 		.enabled = 1, .loglevel = LOGL_NOTICE,
             : 	},
same here. There is no SMPP, and also no RANAP (below) in the BSC. I will send a patch to clean this up.



-- 
To view, visit https://gerrit.osmocom.org/c/openbsc/+/17605
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Change-Id: Id2bca6ec3d29a3d10e84f9b3067be09b64a6b587
Gerrit-Change-Number: 17605
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 01 Apr 2020 09:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200401/54f581f1/attachment.htm>