Change in pysim[master]: Move parsing of PLMNwAcT to generic Card class

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Apr 1 08:52:11 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17661 )

Change subject: Move parsing of PLMNwAcT to generic Card class
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/17661/1/pySim/cards.py 
File pySim/cards.py:

https://gerrit.osmocom.org/c/pysim/+/17661/1/pySim/cards.py@101 
PS1, Line 101: 		if sw == '9000':
> for PLMNwAcT there is further processing required (the same for OPLMNwAcT, HPLMNwAcT), so is it stil […]
oh, sorry, I didin't see the format_xplmn_w_act() function. nevermind for this one then.  If you like the idea, you mihgt want to implement a dictionary of 'transform' functions.  So that you hav a generic methid like read('PLMNwAcT') which then does the _scc.read_binary(EF['PLMNwAcT]), contains the if-clause and in case of success (90000) checks if the dict has an entry for 'PLMNwAcT'.  If yes, it could call the function reference in that dict, and return.  That way we save all this copy+paste boilerplate code.

But not required, this is just an idea...



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/17661
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I14d7c2dc51fac6d5cf4a708a77ad23d252ba6094
Gerrit-Change-Number: 17661
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 01 Apr 2020 08:52:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: herlesupreeth <herlesupreeth at gmail.com>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200401/6c49ec75/attachment.htm>


More information about the gerrit-log mailing list