Change in ...libosmocore[master]: cosmetic: clarify c_iflag in osmo_serial_init()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Sep 28 11:18:09 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/15617 )

Change subject: cosmetic: clarify c_iflag in osmo_serial_init()
......................................................................

cosmetic: clarify c_iflag in osmo_serial_init()

We first set the ISTRIP bit only to remove it in the next line.
Let's try to avoid confusing the reader.

Change-Id: Icba43dd4b6dc4f9c7f8fcf91d24b3baac4e0c74a
---
M src/serial.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/serial.c b/src/serial.c
index 1b5a4cf..31cb81d 100644
--- a/src/serial.c
+++ b/src/serial.c
@@ -97,7 +97,7 @@
 	tio.c_cflag &= ~(PARENB | CSTOPB | CSIZE | CRTSCTS);
 	tio.c_cflag |=  (CREAD | CLOCAL | CS8);
 	tio.c_lflag &= ~(ICANON | ECHO | ECHOE | ISIG);
-	tio.c_iflag |=  (INPCK | ISTRIP);
+	tio.c_iflag |=  (INPCK);
 	tio.c_iflag &= ~(ISTRIP | IXON | IXOFF | IGNBRK | INLCR | ICRNL | IGNCR);
 	tio.c_oflag &= ~(OPOST | ONLCR);
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15617
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icba43dd4b6dc4f9c7f8fcf91d24b3baac4e0c74a
Gerrit-Change-Number: 15617
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190928/49d88486/attachment.htm>


More information about the gerrit-log mailing list