Change in ...osmo-bts[master]: log: set L1 SAPI log context

[osmith]

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 )

Change subject: log: set L1 SAPI log context
......................................................................


Patch Set 6: -Code-Review

(5 comments)

Updated.

Now only the TTCN-3 test needs to be updated; therefore I'll set this to WIP again. The TTCN-3 test does not pass since the rewrite in patchset 5, because we are not setting the log context as soon as a message from the PCU socket arrives. It gets set at a later point now, before sending the data to the BTS specific code.

https://gerrit.osmocom.org/#/c/15539/5/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/#/c/15539/5/src/common/l1sap.c@329 
PS5, Line 329: 	switch(OSMO_PRIM_HDR(&l1sap->oph)) {
> cosmetic: 'switch' is not a function
Done


https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-litecell15/l1_if.c 
File src/osmo-bts-litecell15/l1_if.c:

https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-litecell15/l1_if.c@801 
PS5, Line 801: 	case GsmL1_Sapi_Idle:
> a 'const' look-up table indexed by GsmL1_Sapi would be faster, as it's not going to traverse dozens  […]
Done


https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-oc2g/l1_if.c 
File src/osmo-bts-oc2g/l1_if.c:

https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-oc2g/l1_if.c@852 
PS5, Line 852: 	switch(sapi) {
> same here regarding the lookup table approach.
Done


https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-octphy/l1_if.c 
File src/osmo-bts-octphy/l1_if.c:

https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-octphy/l1_if.c@943 
PS5, Line 943: 	switch(sapi) {
> again same...
Done


https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-sysmo/l1_if.c 
File src/osmo-bts-sysmo/l1_if.c:

https://gerrit.osmocom.org/#/c/15539/5/src/osmo-bts-sysmo/l1_if.c@803 
PS5, Line 803: 		return L1SAP_COMMON_SAPI_IDLE;
> ...
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
Gerrit-Change-Number: 15539
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Fri, 27 Sep 2019 13:34:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190927/589741d4/attachment.htm>