Change in ...osmo-pcu[master]: tbf_dl: Setup m_llc_timer in constructor using osmocom API

[pespin]

pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15606 )

Change subject: tbf_dl: Setup m_llc_timer in constructor using osmocom API
......................................................................

tbf_dl: Setup m_llc_timer in constructor using osmocom API

Change-Id: I3e761b319326e33ab1d56c4fb30cafe3b0f96c29
---
M src/tbf_dl.cpp
1 file changed, 1 insertion(+), 5 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved



diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index fdd9ba3..23887d1 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -87,6 +87,7 @@
 	m_dl_egprs_ctrs(NULL)
 {
 	memset(&m_llc_timer, 0, sizeof(m_llc_timer));
+	osmo_timer_setup(&m_llc_timer, llc_timer_cb, this);
 }
 
 void gprs_rlcmac_dl_tbf::cleanup()
@@ -98,11 +99,6 @@
 {
 	if (bts_data()->llc_idle_ack_csec > 0) {
 		struct timeval tv;
-
-		/* TODO: this ought to be within a constructor */
-		m_llc_timer.data = this;
-		m_llc_timer.cb = &llc_timer_cb;
-
 		csecs_to_timeval(bts_data()->llc_idle_ack_csec, &tv);
 		osmo_timer_schedule(&m_llc_timer, tv.tv_sec, tv.tv_usec);
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15606
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3e761b319326e33ab1d56c4fb30cafe3b0f96c29
Gerrit-Change-Number: 15606
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190927/ef56e5cb/attachment.htm>