Change in ...osmo-ttcn3-hacks[master]: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Thu Sep 26 09:11:29 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )

Change subject: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases
......................................................................


Patch Set 9: Code-Review+1

(2 comments)

> Patch Set 9:
> 
> All comments should be addressed now (I hope).

Yes, I read through the comments again and everything is resolved.

In the code, there are still a few TODOs and FIXMEs, but I think it is good enough as initial version (so we can start implementing tests based on this).

Thank you very much for the patch and for updating it!

https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn 
File pcu/PCUIF_RAW_Components.ttcn:

https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@85 
PS8, Line 85: 	// port RAW_PCU_MSG_PT CCCH;  /* SAPI: PCU_IF_SAPI_{BCCH,PCH,RACH,AGCH} */
> Yep, maybe some day one would find this idea useful. […]
I like how you have implemented it with queues now.


https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@182 
PS8, Line 182: 		MTC.send(RAW_PCU_EVENT:PCU_EV_CONNECT);
> I agree with pespin here.
This is resolved with the "direct" variable.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 9
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Sep 2019 09:11:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: laforge <laforge at gnumonks.org>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190926/706f448f/attachment.htm>


More information about the gerrit-log mailing list