Change in ...osmo-msc[master]: sgs_iface: Accept messages with unknown TLV elements

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Tue Sep 24 10:21:32 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/15599 )

Change subject: sgs_iface: Accept messages with unknown TLV elements
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

We should clearly distinguish presence of unknown IEs and other parsing errors.

https://gerrit.osmocom.org/#/c/15599/1/src/libmsc/sgs_iface.c 
File src/libmsc/sgs_iface.c:

https://gerrit.osmocom.org/#/c/15599/1/src/libmsc/sgs_iface.c@947 
PS1, Line 947: tlv_parse
What if a received message is malformed somehow? Is there any specific value that is returned by tlv_parse() if a massage is correct, but contains unknown IEs?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/15599
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic6714451ad970043d4765f8420d753daf5294a44
Gerrit-Change-Number: 15599
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 24 Sep 2019 10:21:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190924/b72e2be1/attachment.htm>


More information about the gerrit-log mailing list