This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15575 ) Change subject: stream_test: Use fake time ...................................................................... stream_test: Use fake time By using fake own-controlled time we get two benefits: * Test doesn't take 9 seconds to run anymore * More fine-grade control of different events happening (and associated race conditions). Change-Id: I16b2884b289bfe40dfb8d743dce01bb4c208d117 --- M tests/stream/stream_test.c 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/tests/stream/stream_test.c b/tests/stream/stream_test.c index 439ea1a..4fd8573 100644 --- a/tests/stream/stream_test.c +++ b/tests/stream/stream_test.c @@ -19,9 +19,12 @@ #include <osmocom/core/msgb.h> #include <osmocom/core/logging.h> #include <osmocom/core/application.h> +#include <osmocom/core/timer.h> #include <osmocom/netif/stream.h> +#define RECONNECT_TIMEOUT_SECS 9 + #define DSTREAMTEST 0 struct log_info_cat osmo_stream_test_cat[] = { [DSTREAMTEST] = { @@ -100,6 +103,7 @@ /* N. B: normally receiving 0 bytes means that we should close the connection and re-establish it but to test autoreconnection logic we ignore it in here to let the test run till completion */ LOGCLI(cli, "0-byte read, auto-reconnect will be triggered if enabled\n"); + osmo_gettimeofday_override_add(RECONNECT_TIMEOUT_SECS, 0); } if (!cli_data) { @@ -116,7 +120,7 @@ static struct osmo_stream_cli *init_client_reconnection(struct osmo_stream_cli *cli, bool autoreconnect) { /* setting negative timeout ensures that we disable reconnection logic */ - osmo_stream_cli_set_reconnect_timeout(cli, autoreconnect ? 9 : -1); + osmo_stream_cli_set_reconnect_timeout(cli, autoreconnect ? RECONNECT_TIMEOUT_SECS : -1); if (osmo_stream_cli_open(cli) < 0) { LOGCLI(cli, "unable to open client\n"); @@ -352,6 +356,9 @@ char *host = "127.0.0.11"; unsigned port = 1111; void *tall_test = talloc_named_const(NULL, 1, "osmo_stream_test"); + + osmo_gettimeofday_override = true; + msgb_talloc_ctx_init(tall_test, 0); osmo_init_logging2(tall_test, &osmo_stream_test_log_info); log_set_log_level(osmo_stderr_target, LOGL_INFO); -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I16b2884b289bfe40dfb8d743dce01bb4c208d117 Gerrit-Change-Number: 15575 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190920/15603b2a/attachment.htm>