This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430 )
Change subject: Introduce PCUIF, BTS and ClckGen components for RAW PCU test cases
......................................................................
Patch Set 8:
(6 comments)
https://gerrit.osmocom.org/#/c/15430/8//COMMIT_MSG
Commit Message:
https://gerrit.osmocom.org/#/c/15430/8//COMMIT_MSG@42
PS8, Line 42: +-----+ +----------+ +---------+
> May make sense moving this to the tests .ttcn file to have it always available easily.
ACK, I will add this diagram to PCUIF_RAW_Components.ttcn.
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn
File pcu/PCUIF_RAW_Components.ttcn:
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@33
PS8, Line 33: Genetic
> "Generic"? ;)
:D
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@85
PS8, Line 85: // port RAW_PCU_MSG_PT CCCH; /* SAPI: PCU_IF_SAPI_{BCCH,PCH,RACH,AGCH} */
> These commented out ports look like leftovers. Are they still userful? […]
Yep, maybe some day one would find this idea useful. While trying to implement it, I realized that we're getting more complication than benefits :/
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@136
PS8, Line 136: if (pcu_msg.bts_nr != bts_nr) {
> Why can't we always set the correct bts nr in the test case sending the pcu_msg?
It may be useful for multi-BTS tests to send a single message to a single MTC:BTS port, so every BTS component will resend it to the PCU as its own (with proper bts_nr). But then we're loosing a possibility to send a message to particular BTS component, so I'll better remove this.
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCUIF_RAW_Components.ttcn@182
PS8, Line 182: MTC.send(RAW_PCU_EVENT:PCU_EV_CONNECT);
> but not both at the same time?
Why not? One may still want to receive this (or any other) event in the MTC (test case). I don't see any problem with sending to both MTC and all connected BTS components.
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCU_Tests_RAW.ttcn
File pcu/PCU_Tests_RAW.ttcn:
https://gerrit.osmocom.org/#/c/15430/8/pcu/PCU_Tests_RAW.ttcn@472
PS8, Line 472: connect(vc_PCUIF:MTC, self:PCUIF);
> Are you sure you need to connect A->B and B->A two times?
Right, this is redundant. To be removed in the next patch set.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15430
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I63a23abebab88fd5318eb4d907d6028e7c38e9a3
Gerrit-Change-Number: 15430
Gerrit-PatchSet: 8
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Sep 2019 11:23:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: osmith <osmith at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190919/2152936a/attachment.htm>