Change in ...libosmocore[master]: tdef: Introduce min_val and max_val fields

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15546 )

Change subject: tdef: Introduce min_val and max_val fields
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/15546/3/src/vty/tdef_vty.c 
File src/vty/tdef_vty.c:

https://gerrit.osmocom.org/#/c/15546/3/src/vty/tdef_vty.c@188 
PS3, Line 188: ULONG_MAX
Are you sure it's safe to print this macro? Maybe rather print "INF" as string? Or print min/max values separately?

  vty_out(vty, ", min %lu", ...);
  if (t->max_val)
    vty_out(vty, ", max %lu", ...);


https://gerrit.osmocom.org/#/c/15546/3/tests/tdef/tdef_vty_test_config_root.vty 
File tests/tdef/tdef_vty_test_config_root.vty:

https://gerrit.osmocom.org/#/c/15546/3/tests/tdef/tdef_vty_test_config_root.vty@25 
PS3, Line 25: 18446744073709551615
This value may be different on some architectures, so this test will fail.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15546
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I4661ac41c29a009a1d5fc57d87aaee6041c7d1b2
Gerrit-Change-Number: 15546
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Wed, 18 Sep 2019 17:29:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/33d95b01/attachment.htm>