This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 ) Change subject: log: set L1 SAPI context ...................................................................... Patch Set 4: (2 comments) As I've read through both osmo-bts patches, I realized that it makes more sense to put the osmo_bts_filter_fn() function into the other patch. That way, this first patch only sets the log context. So I've moved it. https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c File src/common/logging.c: https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c@148 PS3, Line 148: static int filter_fn(const struct log_context *ctx, struct log_target *tgt) > (personally would prefer "osmo_bts_filter_fn()" to not overload other generally named filter_fn()s f […] Done. https://gerrit.osmocom.org/#/c/15539/3/src/common/logging.c@158 PS3, Line 158: return 1; > Looking at osmo_bsc_main.c filter_fn(), it seems that the intention is this: […] Thank you very much for explaining, updated this code and the test to properly use "logging set filter". -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b Gerrit-Change-Number: 15539 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at gnumonks.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-Comment-Date: Wed, 18 Sep 2019 07:47:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Comment-In-Reply-To: osmith <osmith at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190918/db3f4c35/attachment.htm>