Change in ...osmo-bts[master]: log: set L1 SAPI context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Sep 17 13:29:59 UTC 2019


osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 )

Change subject: log: set L1 SAPI context
......................................................................


Patch Set 2:

> It's a bit confusing to see that you're adding VTY commands and the related logic, and starting to use the logging context for PCU related code in the same change. Maybe rather split them up?

Done

> why is this "PCU" related?  I really don't get how the PCU plays into all of this.  The L1 SAPI is a property of the L1.

I thought it made sense to put the "struct gsm_pcu_if_data" into the log context... but now I understand, that this does not make sense. Updated to actually save the L1 SAPI as log context.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
Gerrit-Change-Number: 15539
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Tue, 17 Sep 2019 13:29:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190917/ff26366a/attachment.htm>


More information about the gerrit-log mailing list