Change in ...libosmocore[master]: logging.h: add SAPI related context and filter

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Sep 16 15:17:16 UTC 2019


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15538 )

Change subject: logging.h: add SAPI related context and filter
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/15538/1/include/osmocom/core/logging.h 
File include/osmocom/core/logging.h:

https://gerrit.osmocom.org/#/c/15538/1/include/osmocom/core/logging.h@157 
PS1, Line 157: LOG_CTX_PCU_IF_DATA
this doesn't really explain what it is about.  The above elements in the enum are self-explanatory, as it's quite clear what a NSVC, BVC or subscriber is.  But what's PCU_IF_DATA? 

Also if this is about filtering by L1 SAPI, then make sure that L1 SAPI is mentioned.  SAPIs exist potentially at any SAP, and there are plenty of SAPs in the protocol stacks: one at every layer boundary.

Furthermore, if we introduce something to libosmocore which is about L1 SAPI filtering, and we do have a L1 SAP (and hence L1 SAPI) in multiple programs, why is something called "PCU" here?



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15538
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I814cb3328d99faca9220adb5a80ffb934f219d7d
Gerrit-Change-Number: 15538
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Sep 2019 15:17:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190916/70f7b10e/attachment.htm>


More information about the gerrit-log mailing list