Change in ...osmo-ttcn3-hacks[master]: sgsn: replace variable gb_index with ran_index

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

lynxis lazus gerrit-no-reply at lists.osmocom.org
Mon Sep 16 13:57:02 UTC 2019


lynxis lazus has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15528 )

Change subject: sgsn: replace variable gb_index with ran_index
......................................................................

sgsn: replace variable gb_index with ran_index

Since gb_index also been used for Iu connection,
rename the variable to ran_index.
Be consistent and use the same variable name everywhere.

Change-Id: I06b0c6184daeb886e8bd28d50bf18909d9244dc6
---
M sgsn/SGSN_Tests.ttcn
1 file changed, 7 insertions(+), 7 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn
index be4283e..084f167 100644
--- a/sgsn/SGSN_Tests.ttcn
+++ b/sgsn/SGSN_Tests.ttcn
@@ -493,16 +493,16 @@
 	return gb_idx >= NUM_GB;
 }
 
-function f_send_llc(template (value) PDU_LLC llc_pdu, integer gb_index := 0) runs on BSSGP_ConnHdlr {
+function f_send_llc(template (value) PDU_LLC llc_pdu, integer ran_index := 0) runs on BSSGP_ConnHdlr {
 	var octetstring llc_enc := enc_PDU_LLC(valueof(llc_pdu));
-	BSSGP[gb_index].send(ts_BSSGP_UL_UD(g_pars.tlli, g_pars.bssgp_cell_id[gb_index], llc_enc));
+	BSSGP[ran_index].send(ts_BSSGP_UL_UD(g_pars.tlli, g_pars.bssgp_cell_id[ran_index], llc_enc));
 }
 
-private function f_send_l3_gmm_llc(template (value) PDU_L3_MS_SGSN l3_mo, integer gb_index := 0) runs on BSSGP_ConnHdlr {
+private function f_send_l3_gmm_llc(template (value) PDU_L3_MS_SGSN l3_mo, integer ran_index := 0) runs on BSSGP_ConnHdlr {
 	var octetstring l3_enc := enc_PDU_L3_MS_SGSN(valueof(l3_mo));
 	var BIT4 sapi := f_llc_sapi_by_l3_mo(valueof(l3_mo));
 	var integer n_u := f_llc_get_n_u_tx(llc[bit2int(sapi)]);
-	f_send_llc(ts_LLC_UI(l3_enc, sapi, '0'B, n_u), gb_index);
+	f_send_llc(ts_LLC_UI(l3_enc, sapi, '0'B, n_u), ran_index);
 }
 
 /* trigger sending of a RANAP InitialUE and wait for SCCP connection confirmation */
@@ -539,8 +539,8 @@
 }
 
 /* send a L3 (GMM/SM) message over whatever is the appropriate lower-layer bearer */
-function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo, integer gb_index := 0) runs on BSSGP_ConnHdlr {
-	if (is_iu(gb_index)) {
+function f_send_l3(template (value) PDU_L3_MS_SGSN l3_mo, integer ran_index := 0) runs on BSSGP_ConnHdlr {
+	if (is_iu(ran_index)) {
 		if (g_pars.rnc_send_initial_ue) {
 			g_pars.rnc_send_initial_ue := false;
 			f_send_l3_initial_ue(l3_mo);
@@ -548,7 +548,7 @@
 			BSSAP.send(ts_PDU_DTAP_PS_MO(l3_mo));
 		}
 	} else {
-		f_send_l3_gmm_llc(l3_mo, gb_index);
+		f_send_l3_gmm_llc(l3_mo, ran_index);
 	}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I06b0c6184daeb886e8bd28d50bf18909d9244dc6
Gerrit-Change-Number: 15528
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190916/87bd8a7a/attachment.htm>


More information about the gerrit-log mailing list