Change in ...pysim[master]: pySim-prog: check if CSV file exists

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Sep 14 15:34:33 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/pysim/+/15495 )

Change subject: pySim-prog: check if CSV file exists
......................................................................

pySim-prog: check if CSV file exists

At the moment we do not chack if the CSV file exists at all. This may
lead into a crash while programming the card. Lets check the CSV file
before we start.

Change-Id: I2643996282d88e512c17901ab0e1181677d5dd6c
Related: SYS#4654
---
M pySim-prog.py
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/pySim-prog.py b/pySim-prog.py
index e92654d..ee5bc98 100755
--- a/pySim-prog.py
+++ b/pySim-prog.py
@@ -712,6 +712,13 @@
 	# Create command layer
 	scc = SimCardCommands(transport=sl)
 
+	# If we use a CSV file as data input, check if the CSV file exists.
+	if opts.source == 'csv':
+		print "Using CSV file as data input: " + str(opts.read_csv)
+		if not os.path.isfile(opts.read_csv):
+			print "CSV file not found!"
+			sys.exit(1)
+
 	# Batch mode init
 	init_batch(opts)
 

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/15495
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I2643996282d88e512c17901ab0e1181677d5dd6c
Gerrit-Change-Number: 15495
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190914/1d1fcab9/attachment.htm>


More information about the gerrit-log mailing list