Change in ...osmo-pcu[master]: tbf_dl: add comments to the scheduler

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15466 )

Change subject: tbf_dl: add comments to the scheduler
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.osmocom.org/#/c/15466/1/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/#/c/15466/1/src/tbf_dl.cpp@362 
PS1, Line 362: 	/* search for an nacked or resend marked bsn */
a nacked


https://gerrit.osmocom.org/#/c/15466/1/src/tbf_dl.cpp@416 
PS1, Line 416: 		/* Is the TBF is in finished, we already sent all packages at least once.
If the


https://gerrit.osmocom.org/#/c/15466/1/src/tbf_dl.cpp@417 
PS1, Line 417: 		 * If any packages could have been send (because of unacked) it should have
sent


https://gerrit.osmocom.org/#/c/15466/1/src/tbf_dl.cpp@427 
PS1, Line 427: 		 * Restart the bsn_cycle to resent all unacked messages */
resend


https://gerrit.osmocom.org/#/c/15466/1/src/tbf_dl.cpp@445 
PS1, Line 445: 		 * Mark unacked bsns as resend */
not sure if it's resend or resent here (depending on what you actually mean).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15466
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib037f9fda30472313c7a82effb1e925c6abebbe5
Gerrit-Change-Number: 15466
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 10 Sep 2019 14:21:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190910/418ea483/attachment.htm>