Change in ...osmo-bts[master]: bts-trx: Log case where no SETFORMAT is sent

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/15460


Change subject: bts-trx: Log case where no SETFORMAT is sent
......................................................................

bts-trx: Log case where no SETFORMAT is sent

If VTY cmd "osmotrx trxd-max-version 0" is used, max version 0 is used
(default starting one) and hence no need to send SETFORMAT (this is
useful in order to avoid sending SETFORMAT to old TRX implementations
not supporting the command). In this case, let's inform the user that
indeed osmo-bts won't send SETFORMAT because version 0 is assumed.

Change-Id: I7136ea6745c2275278bc400676b58fb4b10da966
---
M src/osmo-bts-trx/l1_if.c
1 file changed, 12 insertions(+), 5 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/60/15460/1

diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index 22ef2d7..7e49064 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -185,7 +185,8 @@
 int l1if_provision_transceiver_trx(struct trx_l1h *l1h)
 {
 	uint8_t tn;
-	struct phy_link *plink = l1h->phy_inst->phy_link;
+	struct phy_instance *pinst = l1h->phy_inst;
+	struct phy_link *plink = pinst->phy_link;
 
 	if (!transceiver_available)
 		return -EIO;
@@ -210,10 +211,16 @@
 		}
 
 		/* Ask transceiver to use the newest TRXD header version if not using it yet */
-		if (!l1h->config.setformat_sent &&
-		    l1h->config.trxd_hdr_ver_use != plink->u.osmotrx.trxd_hdr_ver_max) {
-			trx_if_cmd_setformat(l1h, plink->u.osmotrx.trxd_hdr_ver_max);
-			l1h->config.trxd_hdr_ver_req = plink->u.osmotrx.trxd_hdr_ver_max;
+		if (!l1h->config.setformat_sent) {
+			if (l1h->config.trxd_hdr_ver_use != plink->u.osmotrx.trxd_hdr_ver_max) {
+				trx_if_cmd_setformat(l1h, plink->u.osmotrx.trxd_hdr_ver_max);
+				l1h->config.trxd_hdr_ver_req = plink->u.osmotrx.trxd_hdr_ver_max;
+			} else {
+				LOGPPHI(pinst, DL1C, LOGL_INFO,
+					"No need to negotiate TRXD version, "
+					"already using maximum configured one: %" PRIu8 "\n",
+					l1h->config.trxd_hdr_ver_use);
+			}
 			l1h->config.setformat_sent = 1;
 		}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15460
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7136ea6745c2275278bc400676b58fb4b10da966
Gerrit-Change-Number: 15460
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190910/e8cb2ac0/attachment.htm>