Change in ...osmo-bts[master]: osmo-bts-trx/scheduler: add FIXME note about FACCH/H and BFI

[fixeria]

fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-bts/+/15442 )

Change subject: osmo-bts-trx/scheduler: add FIXME note about FACCH/H and BFI
......................................................................

osmo-bts-trx/scheduler: add FIXME note about FACCH/H and BFI

Change-Id: Ie006cd46cb574d272fbe3b38595a3087617c79d1
---
M src/osmo-bts-trx/scheduler_trx.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, approved



diff --git a/src/osmo-bts-trx/scheduler_trx.c b/src/osmo-bts-trx/scheduler_trx.c
index 57eb138..1249053 100644
--- a/src/osmo-bts-trx/scheduler_trx.c
+++ b/src/osmo-bts-trx/scheduler_trx.c
@@ -1466,6 +1466,8 @@
 			0 /* FIXME: AVG C/I */,
 			ber10k, PRES_INFO_UNKNOWN);
 bfi:
+		/* FIXME: a FACCH/H frame replaces two speech frames,
+		 * so we actually need to send two bad frame indications! */
 		if (rsl_cmode == RSL_CMOD_SPD_SPEECH) {
 			/* indicate bad frame */
 			switch (tch_mode) {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15442
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie006cd46cb574d272fbe3b38595a3087617c79d1
Gerrit-Change-Number: 15442
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190907/712fcdb7/attachment.htm>