Change in ...osmo-pcu[master]: Introduce osmo_tdef infra and timer VTY commands

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 )

Change subject: Introduce osmo_tdef infra and timer VTY commands
......................................................................


Patch Set 2:

(5 comments)

https://gerrit.osmocom.org/#/c/15425/2/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/#/c/15425/2/src/bts.cpp@71 
PS2, Line 71: #define T3142_SECS 20
            : #define T3169_SECS 5
            : #define T3191_SECS 5
            : #define T3193_MSECS 100
            : #define T3195_SECS 5
            : #define X2000_MSECS 2
            : #define X2001_SECS 2
            : #define X2002_MSECS 200
Do we really need these macros? I don't see they're used anywhere else...


https://gerrit.osmocom.org/#/c/15425/2/src/bts.cpp@87 
PS2, Line 87: timeout
Cosmetic: timeout happens when timer expires, not sure if this word is applicable here.


https://gerrit.osmocom.org/#/c/15425/2/src/bts.cpp@595 
PS2, Line 595: -2002
Looks odd to me, could you please add a comment? Why exactly -2002?


https://gerrit.osmocom.org/#/c/15425/2/src/pcu_l1_if.cpp 
File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/#/c/15425/2/src/pcu_l1_if.cpp@a211 
PS2, Line 211: 
Unrelated ws fix.


https://gerrit.osmocom.org/#/c/15425/2/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/#/c/15425/2/src/tbf.cpp@664 
PS2, Line 664: enum tbf_timers t,
Do you think we still need this parameter? Most of the time I see: T_START(tbf, TXXX, XXX, ...), but I also see confusing T_START(tbf, TXXX, -XXX, ...), so it's getting even more confusing. I am definitely missing something...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15425
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I5cfb9ef01706124be262d4536617b9edb4601dd5
Gerrit-Change-Number: 15425
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at gnumonks.org>
Gerrit-Comment-Date: Fri, 06 Sep 2019 21:17:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190906/566204b5/attachment.htm>