Change in ...libosmo-sccp[master]: ss7: Do not queue messages if stream is not connected

[pespin]

pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/15405 )

Change subject: ss7: Do not queue messages if stream is not connected
......................................................................

ss7: Do not queue messages if stream is not connected

Consider them as lost by the lower layer, otherwise lots of old messages
and retransmissions can end up queued in there until stream becomes
connected, and then will flood the peer with all those messages.

Depends: libosmo-netif.git 962bf9a48eed418354685dc733b8271d2dd62c27
Related: OS#4188
Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
---
M src/osmo_ss7.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  daniel: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index e8a6918..053feca 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1810,6 +1810,11 @@
 			msgb_free(msg);
 			return -EIO;
 		}
+		if (!osmo_stream_cli_is_connected(asp->client)) {
+			LOGPASP(asp, DLSS7, LOGL_ERROR, "Cannot transmit, asp->client not connected\n");
+			msgb_free(msg);
+			return -EIO;
+		}
 		osmo_stream_cli_send(asp->client, msg);
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/15405
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ic7d3571848faf28221dcfa8eb8b33b42964d988e
Gerrit-Change-Number: 15405
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190906/6c53b409/attachment.htm>