Change in ...osmo-ttcn3-hacks[master]: library/GSM_RR_Types.ttcn: fix: IA Rest Octets may have optional padding

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Sep 5 16:21:34 UTC 2019


laforge has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15429 )

Change subject: library/GSM_RR_Types.ttcn: fix: IA Rest Octets may have optional padding
......................................................................

library/GSM_RR_Types.ttcn: fix: IA Rest Octets may have optional padding

According to 3GPP TS 04.08 (version 7.21.0), section 10.5.2.16 and
table 10.5.45, IA Rest Octets IE may contain spare bits. Let's add
an optional field 'pad' to record 'IaRestOctets'.

NOTE: somehow this change crashes my TITAN runtime:

  dec_GsmRrMessage(): Stream before decoding: '2D063F100FE3673A096B0000C800300B2B2B2B2B2B2B2B'O
  *** Error in `././PCU_Tests': malloc(): memory corruption: 0x000000000074a790 ***

while the recent version works just fine.

Change-Id: Ifdcdcf50709fcc03195cb8ef6092977e26f910ec
---
M library/GSM_RR_Types.ttcn
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/library/GSM_RR_Types.ttcn b/library/GSM_RR_Types.ttcn
index 627f78f..f313e23 100644
--- a/library/GSM_RR_Types.ttcn
+++ b/library/GSM_RR_Types.ttcn
@@ -543,7 +543,8 @@
 		IaRestOctLL	ll optional,
 		IaRestOctLH	lh optional,
 		IaRestOctHL	hl optional,
-		IaRestOctHH	hh optional
+		IaRestOctHH	hh optional,
+		bitstring	pad optional
 	} with {
 		variant (ll) "PRESENCE(presence = '00'B)"
 		variant (lh) "PRESENCE(presence = '01'B)"

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15429
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifdcdcf50709fcc03195cb8ef6092977e26f910ec
Gerrit-Change-Number: 15429
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190905/57178f46/attachment.htm>


More information about the gerrit-log mailing list