Change in ...osmo-bts[master]: pcu_interface: Forward ETWS Primary Notification to PCU

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Sep 5 14:00:13 UTC 2019


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15420 )

Change subject: pcu_interface: Forward ETWS Primary Notification to PCU
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/#/c/15420/2/src/common/paging.c 
File src/common/paging.c:

https://gerrit.osmocom.org/#/c/15420/2/src/common/paging.c@548 
PS2, Line 548: printf
Looks like a debug left-over.


https://gerrit.osmocom.org/#/c/15420/2/src/common/pcu_sock.c 
File src/common/pcu_sock.c:

https://gerrit.osmocom.org/#/c/15420/2/src/common/pcu_sock.c@304 
PS2, Line 304: if (app_type & 0xF0 || len > sizeof(ai_req->data)) {
Makes sense to do this check before allocating the msgb.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15420
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ic0b3f38b400a0ca7e4089061ceb6548b0695faa6
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Thu, 05 Sep 2019 14:00:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190905/6d807faf/attachment.htm>


More information about the gerrit-log mailing list