Change in ...libosmo-netif[master]: stream: Introduce API osmo_stream_cli_is_connected

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Sep 5 09:43:07 UTC 2019


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/15403 )

Change subject: stream: Introduce API osmo_stream_cli_is_connected
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> It might make sense to think about exposing the state in general, so that we could just have a "get_state" function and an enum for the states.  But I'm happy to merge this check for only a single of the possible states as-is.

My impression is that (contrary to what's usually done in osmocom code) the API is designed to hide most implementation details (data structures, etc.), so I think simply asking if the stream is connected is enough for now.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/15403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I5402430e5f39eef22dfa18f33807ab6b1e771f1b
Gerrit-Change-Number: 15403
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at gnumonks.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Sep 2019 09:43:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20190905/99e068b4/attachment.htm>


More information about the gerrit-log mailing list